Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #362 set URI for destination of EventGrid #364

Merged

Conversation

philippeckelintive
Copy link
Contributor

fixes #362

@philippeckelintive
Copy link
Contributor Author

@mvantellingen any chance to get this in soonish?

@okkevandereijk
Copy link
Member

okkevandereijk commented May 22, 2023

@philippeckelintive Thanks for fixing this! Verified that the URI destination is now propagated to Commercetools. Seems that our mock library server we use does not have an implementation for subscriptions and therefore we don't see it appear as an error (cc @mvantellingen @pimvernooij)

@okkevandereijk
Copy link
Member

Created issue labd/commercetools-node-mock#76

@okkevandereijk
Copy link
Member

@philippeckelintive Fix has been released, version 1.7.0: https://github.com/labd/terraform-provider-commercetools/releases/tag/v1.7.0

@rsinha29
Copy link

I am able to run it now , its fixed in the version 1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[commercetools_subscription] Empty string as URI for Azure EventGrid topic
4 participants